Re: Linux 2.6.13-rc4

[Mickey Stein]

Cal Peake wrote:

> On Fri, 29 Jul 2005, Mickey Stein wrote:
>
>  
>
> > This is regarding *-rc4 and *-rc4-git1:  I slapped together my favorite config
> > and gave it a test run. It had a bit of a problem and ground to a halt after
> > spewing these into the log.
> >
> > If I can find the time tomorrow morning, I'll leave parport_pc commented out
> > of modprobe.conf and see if something else pops loose. I don't use the
> > parallel port, but I try to keep a fairly robust config for noticing bugs.
> >    
>
> Hi Mick,
>
> Can you please try the patch below from Linus (or -git2 tomorrow) and 
> confirm that it fixes it for you?
>
> thx,
> -cp
>
> --- a/include/asm-i386/bitops.h
> +++ b/include/asm-i386/bitops.h
> @@ -335,14 +335,13 @@ static inline unsigned long __ffs(unsign
> static inline int find_first_bit(const unsigned long *addr, unsigned size)
> {
> 	int x = 0;
> -	do {
> -		if (*addr)
> -			return __ffs(*addr) + x;
> -		addr++;
> -		if (x >= size)
> -			break;
> +
> +	while (x < size) {
> +		unsigned long val = *addr++;
> +		if (val)
> +			return __ffs(val) + x;
> 		x += (sizeof(*addr)<<3);
> -	} while (1);
> +	}
> 	return x;
> }
>
>  
Hi Cal,

I'll give that a go in about 30 minutes and report back, hopefully on 
*rc4-* ;) . I'm not sure I'll be around in the morning so will apply 
this to today's and see.

Thanks,

Mickey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/