Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)
From: Andi Kleen
Date: Fri Jul 29 2005 - 02:51:16 EST
On Wed, Jul 27, 2005 at 10:03:04PM -0600, Eric W. Biederman wrote:
> I believe this patch suffers from apicid versus logical cpu number confusion.
> I copied the basic logic from smp_send_reschedule and I can't find where
> that translates from the logical cpuid to apicid. So it isn't quite
> correct yet. It should be close enough that it shouldn't be too hard
> to finish it up.
> More bug fixes after I have slept but I figured I needed to get this
> one out for review.
Thanks looks good. This should fix the unexplained
hang for various people. Logical<->apicid is actually ok, the low
level _mask function takes care of that (it differs depending on the
APIC mode anyways)
There are some style problems, but that can be fixed later.
How did you track that nasty it down?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/