Re: Linux 2.4.32-pre2

From: Johannes Erdfelt
Date: Thu Jul 28 2005 - 19:47:24 EST


On Thu, Jul 28, 2005, Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx> wrote:
> diff --git a/drivers/usb/host/uhci.c b/drivers/usb/host/uhci.c
> --- a/drivers/usb/host/uhci.c
> +++ b/drivers/usb/host/uhci.c
> @@ -2924,7 +2924,7 @@ static int alloc_uhci(struct pci_dev *de
> }
>
> /* Only place we don't use the frame list routines */
> - uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle;
> + uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle | UHCI_PTR_QH;
> }
>
> start_hc(uhci);

Am I missing something here? We're certainly adding TDs to the schedule, so
why is this patch setting the QH bit?

JE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/