Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: colormap fixes

From: Antonino A. Daplas
Date: Thu Jul 28 2005 - 17:18:49 EST

Jon Smirl wrote:
Can you review this fix for the issues below? I fixed things to
automatically adjust the number of entries to whatever fits in

diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
--- a/drivers/video/fbsysfs.c
+++ b/drivers/video/fbsysfs.c
@@ -244,15 +244,15 @@ static ssize_t show_virtual(struct class
/* Format for cmap is "%02x%c%4x%4x%4x\n" */
Why is the alpha channel not given the same weight as the RGB? Wouldn't
it be correct to also give it 4 bytes (16 bits) Also, what would happen if
you exceed 256 entries, you've only alloted a maximum of 256 for the
index? This will also be a problem because you cannot access cmap entries
past 255.

So, 4 bytes per channel + 4 bytes for the index will be needed per entry,


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at