Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace

From: Mitchell Blank Jr
Date: Thu Jul 28 2005 - 16:11:35 EST

Still one nitpick:

Jon Smirl wrote:
> + while (isspace(*x) && (x - buffer->page < count))
> + x++;

I think you can just do:

if (count > 0)
while (isspace(*x))

If the passed-in string was fully whitespace then the trailing-whitespace
stripping would already reduce it to count==0. So as long as you check
for that case you can be sure that the while() will stop before x falls off
the end of the string.

Other than that it looks fine to me now.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at