Re: 2.6.13-rc3-mm3

From: Nick Sillik
Date: Thu Jul 28 2005 - 15:59:56 EST


Andrew Morton wrote:
Michael Thonke <iogl64nx@xxxxxxxxx> wrote:

Hello Andrew,

I have some questions :-)
Reiser4:

why there are undefined functions implemented that currently not in use?
This messages appeared first time in 2.6.13-rc3-mm2.

Any why it complains even CONFIG_REISER4_DEBUG is not set?


That's due to the code using `#if CONFIG_xx' instead of `#ifdef'.


I previously posted a patch that got rid of one of these, find it attached again below.

Signed-off-by: Nick Sillik <n.sillik@xxxxxxxxxx> diff -urN a/fs/reiser4/plugin/node/node40.h b/fs/reiser4/plugin/node/node40.h
--- a/fs/reiser4/plugin/node/node40.h 2005-07-27 18:14:04.000000000 -0400
+++ b/fs/reiser4/plugin/node/node40.h 2005-07-27 18:14:53.000000000 -0400
@@ -80,7 +80,7 @@
int check_node40(const znode * node, __u32 flags, const char **error);
int parse_node40(znode * node);
int init_node40(znode * node);
-#if GUESS_EXISTS
+#ifdef GUESS_EXISTS
int guess_node40(const znode * node);
#endif
void change_item_size_node40(coord_t * coord, int by);