[patch 1/2] doc: describe Kbuild pitfall

From: blaisorblade
Date: Thu Jul 28 2005 - 14:48:03 EST

From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>

Whitespace is significant for make, and I just fought against this... so
please apply this patch.

I'm resending since this hasn't been applied for a long time.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>

linux-2.6.git-paolo/Documentation/kbuild/makefiles.txt | 6 ++++++
1 files changed, 6 insertions(+)

diff -puN Documentation/kbuild/makefiles.txt~doc-add-pitfall Documentation/kbuild/makefiles.txt
--- linux-2.6.git/Documentation/kbuild/makefiles.txt~doc-add-pitfall 2005-07-28 17:47:08.000000000 +0200
+++ linux-2.6.git-paolo/Documentation/kbuild/makefiles.txt 2005-07-28 17:47:08.000000000 +0200
@@ -872,7 +872,13 @@ When kbuild executes the following steps
Assignments to $(targets) are without $(obj)/ prefix.
if_changed may be used in conjunction with custom commands as
defined in 6.7 "Custom kbuild commands".
Note: It is a typical mistake to forget the FORCE prerequisite.
+ Another pitfall that bit me once is that whitespace is sometimes
+ significant; for instance, the below will fail (note the extra space
+ after the comma):
+ target: source(s) FORCE
+ $(call if_changed, ld/objcopy/gzip)

Link target. Often LDFLAGS_$@ is used to set specific options to ld.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/