Re: [patch] mm: Ensure proper alignment for node_remap_start_pfn

From: Dave Hansen
Date: Thu Jul 28 2005 - 12:26:01 EST


On Wed, 2005-07-27 at 18:31 -0700, Ravikiran G Thirumalai wrote:
> On Wed, Jul 27, 2005 at 06:17:24PM -0700, Andrew Morton wrote:
> > Ravikiran G Thirumalai <kiran@xxxxxxxxxxxx> wrote:
> > >
> > > While reserving KVA for lmem_maps of node, we have to make sure that
> > > node_remap_start_pfn[] is aligned to a proper pmd boundary.
> > > (node_remap_start_pfn[] gets its value from node_end_pfn[])
> > >
> >
> > What are the effects of not having this patch applied? Does someone's
> > computer crash, or what?
>
> Yes, it does cause a crash.

I don't know of any NUMA x86 sub-arches that have nodes which are
aligned on any less than 2MB. Is this an architecture that's supported
in the tree, today?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/