Re: [PATCH] fbdev: colormap fixes

From: Geert Uytterhoeven
Date: Thu Jul 28 2005 - 11:09:26 EST

On Thu, 28 Jul 2005, Jon Smirl wrote:
> Can you review this fix for the issues below? I fixed things to
> automatically adjust the number of entries to whatever fits in

Looks OK, but...

> @@ -317,18 +317,18 @@ static ssize_t show_cmap(struct class_de
> !fb_info->
> return -EINVAL;
> - if (PAGE_SIZE < 4096)
> + if (fb_info->cmap.len > PAGE_SIZE / 16)
> return -EINVAL;

... perhaps you want to just return the first PAGE_SIZE/16 entries, instead of



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at