Re: [PATCH] compat_sys_read/write

From: Stephen Rothwell
Date: Thu Jul 28 2005 - 09:56:36 EST


On Thu, 28 Jul 2005 15:16:53 +0100 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> This looks totally horrible, especially as we'd need readv/writev and
> pread/pwrite aswell. I don't think anyone but Andi actually liked this
> approach when discussed earlier.

readv/writev were done ages ago (since they are necessary for other
reasons). pread/pwrite I can look at later - but I don't think they would
be used to read/write events from evedv and we do *NOT* want to encourage
people to use read/write on structures (especially ones that need compat_
munging.

I know this is horrible but evdev needs fixing somehow - and I argued for
the other alternative.

And where were you a week ago when I asked if I should post this patch?
And why didn't you guys corner Andi at OLS? :-)

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature