Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node

From: Adrian Bunk
Date: Wed Jul 27 2005 - 15:56:21 EST

On Wed, Jul 27, 2005 at 01:19:00PM -0700, Christoph Lameter wrote:
> On Wed, 27 Jul 2005, Andrew Morton wrote:
> > > return objp;
> > > }
> > > -EXPORT_SYMBOL(kmem_cache_alloc_node);
> > >
> > > #endif
> >
> > Even though we don't currently have in-module users, we probably will do so
> > soon and it's a part of the slab API and the slab API is exported to
> > modules. I don't see much point in partially-exporting the API and
> > applying a patch which we'll soon revert.
> >
> > Christoph?
> >
> I fully agree. Drivers will have to use that call in the future in order
> to properly place their control structures. The e1000 in your tree already
> does so and may be compiled as a module. Thus applying this patch will
> break mm.

I don't see e1000 in 2.6.13-rc3-mm2 using it.

And yes, I tried compilation of as much as possible (including e1000) in
2.6.13-rc3-mm2 with my patch applied before resending it.



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at