Re: [PATCH 0/23] reboot-fixes

From: Eric W. Biederman
Date: Wed Jul 27 2005 - 11:01:56 EST

ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes:

> Andrew Morton <akpm@xxxxxxxx> writes:
>> My fairly ordinary x86 test box gets stuck during reboot on the
>> wait_for_completion() in ide_do_drive_cmd():
> Hmm. The only thing I can think of is someone started adding calls
> to device_suspend() before device_shutdown(). Not understanding
> where it was a good idea I made certain the calls were in there
> consistently.
> Andrew can you remove the call to device_suspend from kernel_restart
> and see if this still happens?
> I would suspect interrupts of being disabled but it looks like
> kgdb is working and I think that requires an interrupt to notice
> new characters.

Looking at it the device_suspend calls should be safe but
in case we need to follow it up the device_suspend calls in sys_reboot
were initially introduced in:

commit 620b03276488c3cf103caf1e326bd21f00d3df84
Author: Pavel Machek <pavel@xxxxxx>
Date: Sat Jun 25 14:55:11 2005 -0700

[PATCH] properly stop devices before poweroff

Without this patch, Linux provokes emergency disk shutdowns and
similar nastiness. It was in SuSE kernels for some time, IIRC.

Signed-off-by: Pavel Machek <pavel@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at