Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG

From: Harald Welte
Date: Tue Jul 26 2005 - 07:59:31 EST


On Sun, Jul 24, 2005 at 07:15:05PM -0700, David S. Miller wrote:

> > I strongly disrecommend increasing NPROTO. Maybe we should look into
> > reusing NETLINK_FIREWALL (which was an old 2.2.x kernel interface).
>
> ip_queue.c still uses NETLINK_FIREWALL so we really can't use
> that.

sorry, I didn't remember that ip_queue reused the 2.2.x netlink number
:( We should have renamed it to make it clear.

> So instead, as in the patch below, I solved this for now by using
> the NETLINK_SKIP value which was reserved years ago yet never
> made use of.

thanks.

--
- Harald Welte <laforge@xxxxxxxxxxxxx> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie

Attachment: pgp00000.pgp
Description: PGP signature