Re: kernel guide to space

[Kyle Moffett]

On Jul 20, 2005, at 20:45:21, Paul Jackson wrote:
> drivers/scsi/BusLogic.c:
>
>   %2d     %5d %5d %5d    %5d %5d %5d       %5d %5d %5d\n",  
> TargetID, TargetStatistics[TargetID].CommandAbortsRequested,  
> TargetStatistics[TargetID].CommandAbortsAttempted, TargetStatistics 
> [TargetID].CommandAbortsCompleted, TargetStatistics 
> [TargetID].BusDeviceResetsRequested, TargetStatistics 
> [TargetID].BusDeviceResetsAttempted, TargetStatistics 
> [TargetID].BusDeviceResetsCompleted, TargetStatistics 
> [TargetID].HostAdapterResetsRequested, TargetStatistics 
> [TargetID].HostAdapterResetsAttempted, TargetStatistics 
> [TargetID].HostAdapterResetsCompleted);

Ugh!!!  From CodingStyle (although this is not always followed):
> The limit on the length of lines is 80 columns and this is a hard  
> limit.
> Statements longer than 80 columns will be broken into sensible chunks.
> Descendants are always substantially shorter than the parent and  
> are placed
> substantially to the right.  The same applies to function headers  
> with a long
> argument list.  Long strings are as well broken into shorter strings.
> [example relevant to the above code snipped]


Also:
> C is a Spartan language, and so should your naming be.  Unlike  
> Modula-2 and
> Pascal programmers, C programmers do not use cute names like
> ThisVariableIsATemporaryCounter.  A C programmer would call that  
> variable
> "tmp", which is much easier to write, and not the least more  
> difficult to
> understand.
>
> [...] mixed-case names are frowned upon [...]

*cough* TargetStatistics[TargetID].HostAdapterResetsCompleted *cough*

I suspect linus would be willing to accept a few cleanup patches for the
BusLogic.c file.  Perhaps even one that renames BusLogic.c to buslogic.c
like all the other files in the source tree, instead of using nasty
StudlyCaps all over :-D

Cheers,
Kyle Moffett

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a18 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$ L++++(+ 
++) E
W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+ PGP+++ t+(+++) 5  
X R?
tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r  !y?(-)
------END GEEK CODE BLOCK------


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/