Re: [RFC][PATCH - 1/12] NTP cleanup: Move NTP code into ntp.c

[john stultz]

On Mon, 2005-07-18 at 13:42 +0200, Pavel Machek wrote:
> Hi!
> > Any comments or feedback would be greatly appreciated.
> > +#ifdef CONFIG_TIME_INTERPOLATION
> > +void time_interpolator_update(long delta_nsec);
> > +#else
> > +#define time_interpolator_update(x)
> 
> do {} while (0) is safer...

Applied. 

> > +	result = time_state;       /* mostly `TIME_OK' */
> > +
> > +	/* Save for later - semantics of adjtime is to return old value */
> > +	save_adjust = time_next_adjust ? time_next_adjust : time_adjust;
> > +
> > +#if 0	/* STA_CLOCKERR is never set yet */
> > +	time_status &= ~STA_CLOCKERR;		/* reset STA_CLOCKERR */
> > +#endif
> 
> Please remove deleted code completely.

Done in a later patch, but good point, I'll kill it in the first one. 


Thanks for the review and feedback! 
-john


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/