Re: [another PATCH] Fix crash on boot in kmalloc_node IDE changes

[Linus Torvalds]

On Thu, 7 Jul 2005, Christoph Lameter wrote:
>
> On Thu, 7 Jul 2005, Linus Torvalds wrote:
> 
> > If you make it use a trivial inline function for the thing, I think that 
> > would be ok, though.
> 
> Like this?

Yes. Except that if hwif is NULL, we'll have other oopses since we access 
that in other places.

Why _is_ hwif NULL anyway? That's another, unrelated thing, and should 
probably have a separate check and an early return.

So there's two unrelated issues: hwif being NULL is a serious error
regardless of any node issues, and pci_dev being NULL just means we aren't
a PCI device.

Bartlomiej?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/