Re: Linux 2.6.13-rc2

From: Greg KH
Date: Wed Jul 06 2005 - 21:26:05 EST


On Wed, Jul 06, 2005 at 09:22:05AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 6 Jul 2005, Greg KH wrote:
> >
> > --- gregkh-2.6.orig/sound/pci/bt87x.c 2005-07-06 08:48:29.000000000 -0700
> > +++ gregkh-2.6/sound/pci/bt87x.c 2005-07-06 08:48:54.000000000 -0700
> > @@ -798,6 +798,8 @@
> > {0x270f, 0xfc00}, /* Chaintech Digitop DST-1000 DVB-S */
> > };
> >
> > +static struct pci_driver driver;
> > +
>
> Hmm.. Shouldn't you at a _minimum_ initialize the name and owner fields?

It's done so a few functions down. This is just a "forward" reference
to the real thing there.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/