Re: slab not freeing with current -git

[Christoph Lameter]

On Wed, 6 Jul 2005, Anton Blanchard wrote:

> Its using the default. Looking at include/asm-generic/topology.h:
> 
> #ifndef pcibus_to_node
> #define pcibus_to_node(node)    (-1)
> #endif
> 
> I wonder what kmalloc_node does when you pass it -1.

That is the issue. It should fall back to kmalloc. One piece of the 
patchset dropped out between Andrew and Linus.

Index: linux-2.6.git/mm/slab.c
===================================================================
--- linux-2.6.git.orig/mm/slab.c	2005-07-05 17:03:30.000000000 -0700
+++ linux-2.6.git/mm/slab.c	2005-07-05 17:04:09.000000000 -0700
@@ -2443,6 +2443,9 @@
 {
 	kmem_cache_t *cachep;
 
+	if (node == -1)
+		return kmalloc(size, flags);
+
 	cachep = kmem_find_general_cachep(size, flags);
 	if (unlikely(cachep == NULL))
 		return NULL;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/