Re: Problem with inotify

From: Anton Altaparmakov
Date: Mon Jul 04 2005 - 10:14:27 EST


On Mon, 2005-07-04 at 15:39 +0100, Anton Altaparmakov wrote:
> On Mon, 2005-07-04 at 15:27 +0100, Anton Altaparmakov wrote:
> > On Sun, 2005-07-03 at 11:34 +0100, Daniel Drake wrote:
> > > I reverted the patch you sent earlier
> > > (inotify_unmount_inodes-list-iteration-fix.diff) and applied the one you
> > > attached here (inotify_unmount_inodes-list-iteration-fix2.diff).
> > >
> > > The good news is that the hang is gone. The bad news is that you cured the
> > > hang by introducing an oops :(
> >
> > )-: I have addressed the only things I can think off that could cause
> > the oops and below is the resulting patch. Could you please test it?
>
> I forgot to say that this patch is a replacement for the previous
> (inotify_unmount_inodes-list-iteration-fix{,2}.diff}.

Note I seem to remember you are using 2.6.12? If so I am not sure when
the I_WILL_FREE stuff came into existence, so should inotify.c not
compile after applying this patch just delete the " | I_WILL_FREE " in
the two places it occurs introduced by the patch and all should be fine.

Best regards,

Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/