Re: IBM HDAPS things are looking up (was: Re: [Hdaps-devel] Re: [ltp] IBM HDAPS Someone interested? (Accelerometer))

From: Pekka Enberg
Date: Mon Jul 04 2005 - 05:55:06 EST


Hi Jesper,

On 7/4/05, Jesper Juhl <jesper.juhl@xxxxxxxxx> wrote:
> static int
> ibm_hdaps_open(struct inode *inode, struct file *filp)
> {
> printk("%s() start\n", __func__);
> if (!atomic_dec_and_test(&ibm_hdaps_available)) {
> printk("%s() busy\n", __func__);
> atomic_inc(&ibm_hdaps_available);
> return -EBUSY;
> }
> printk("%s() good\n", __func__);
>
> filp->private_data = kmalloc(sizeof(struct hdaps_accel_data), GFP_KERNEL);

You seem to be leaking private_data.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/