[PATCH] USB: fix hid core to return proper error code from probe

From: Greg KH
Date: Thu Jun 23 2005 - 01:18:23 EST


[PATCH] USB: fix hid core to return proper error code from probe

Drivers need to return -ENODEV when they can't bind to a device.
Anything else stops the "bind a device to a driver" search.

From: Stelian Pop <stelian@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
commit 479f6ea85e513551510ad52f37e69e1c596ad356
tree 60eadfd85297f42be75be8863cacbc0ea9d82f3b
parent b7c84c6ada2be942eca6722edb2cfaad412cd5de
author Stelian Pop <stelian@xxxxxxxxxx> Wed, 22 Jun 2005 17:53:28 +0200
committer Greg Kroah-Hartman <gregkh@xxxxxxx> Wed, 22 Jun 2005 23:01:09 -0700

drivers/usb/input/hid-core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/input/hid-core.c b/drivers/usb/input/hid-core.c
--- a/drivers/usb/input/hid-core.c
+++ b/drivers/usb/input/hid-core.c
@@ -1762,7 +1762,7 @@ static int hid_probe(struct usb_interfac
intf->altsetting->desc.bInterfaceNumber);

if (!(hid = usb_hid_configure(intf)))
- return -EIO;
+ return -ENODEV;

hid_init_reports(hid);
hid_dump_device(hid);
@@ -1777,7 +1777,7 @@ static int hid_probe(struct usb_interfac
if (!hid->claimed) {
printk ("HID device not claimed by input or hiddev\n");
hid_disconnect(intf);
- return -EIO;
+ return -ENODEV;
}

printk(KERN_INFO);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/