Re: [PATCH 2/2] Fix signed char problem in scripts/kconfig

From: Roman Zippel
Date: Wed Jun 22 2005 - 09:52:21 EST


Hi,

On Wed, 22 Jun 2005, Pierre Ossman wrote:

> The signed characters in scripts are causing warnings with GCC 4 on
> systems with proper string functions (with char*, not signed char* as
> parameters). Some could be kept signed but most had to be reverted to
> normal chars.
>
> Detailed changelog:
>
> mconf.c:
> - buf/bufptr was used in vsprintf() so it couldn't be signed.
> confdata.c:
> - conf_expand_value() used strchr() and strncat() forcing
> "normal" strings.
> conf.c:
> - line was used with several string functions so it couldn't be
> signed.
> - strip() uses strlen() so same thing there.
>
> Signed-off-by: Pierre Ossman <drzeus@xxxxxxxxx>

Acked-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>

Looks good, thanks.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/