Re: [patch] spinlock cleanup

From: Andrew Morton
Date: Tue Jun 21 2005 - 22:45:48 EST


Stas Sergeev <stsp@xxxxxxxx> wrote:
>
> Here is another attempt to
> remove the "extern i8253_lock"
> from the C files.
> It now uses the same #ifdefs for
> including the header and using
> the lock, so it hopefully no
> longer breaks the compilation.
> Does it look good this time?

Adding ifdefs around #includes is a bit unsightly - it also increases the
possibility that the build will break when .configs are changed.

Is it not possible to find an appropriate arch-specific header file for the
declaration?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/