Re: [RFC] cleanup patches for strings

From: Jörn Engel
Date: Tue Jun 21 2005 - 04:37:42 EST


On Tue, 21 June 2005 12:59:22 +0400, Alexey Dobriyan wrote:
>
> > --- linux-2.6.12-orig/drivers/net/ibmlana.c
> > +++ linux-2.6.12/drivers/net/ibmlana.c
>
> > - char *fill = "NetBSD is a nice OS too! ";
> > + char fill[] = "NetBSD is a nice OS too! ";
>
> Don't:
> 5721 16 4 5741 166d drivers/net/ibmlana.o 2.95.3-before
> 5737 16 4 5757 167d drivers/net/ibmlana.o 2.95.3-after
> 5163 16 4 5183 143f drivers/net/ibmlana.o 3.3.5-20050130-before
> 5169 16 4 5189 1445 drivers/net/ibmlana.o 3.3.5-20050130-after
> 4993 16 4 5013 1395 drivers/net/ibmlana.o 4.1-20050604-before
> 5028 16 4 5048 13b8 drivers/net/ibmlana.o 4.1-20050604-after

Please note that all the Dos have the magic word "static" while this
Don't doesn't.

Jörn

--
It is better to die of hunger having lived without grief and fear,
than to live with a troubled spirit amid abundance.
-- Epictetus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/