[PATCH] Fix up USB to use klist_node_attached() instead of list_empty() on lists that will go away.

From: Greg KH
Date: Mon Jun 20 2005 - 21:27:10 EST


[PATCH] Fix up USB to use klist_node_attached() instead of list_empty() on lists that will go away.

Signed-off-by: Patrick Mochel <mochel@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

Index: gregkh-2.6/drivers/usb/core/usb.c
===================================================================

---
commit d4a7537122fa47a6ce41c5fdab53d844c78d7023
tree e4ae3e20f27497c90fca268260c591f117356a3e
parent 8b0c250be489dcbf1a3a33bb4ec4c7f33735a365
author mochel@xxxxxxxxxxxxxxxxxx <mochel@xxxxxxxxxxxxxxxxxx> Thu, 24 Mar 2005 13:00:16 -0800
committer Greg Kroah-Hartman <gregkh@xxxxxxx> Mon, 20 Jun 2005 15:15:17 -0700

drivers/usb/core/usb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -293,7 +293,7 @@ int usb_driver_claim_interface(struct us
/* if interface was already added, bind now; else let
* the future device_add() bind it, bypassing probe()
*/
- if (!list_empty (&dev->bus_list))
+ if (!klist_node_attached (&dev->knode_bus))
device_bind_driver(dev);

return 0;
@@ -323,7 +323,7 @@ void usb_driver_release_interface(struct
return;

/* don't disconnect from disconnect(), or before dev_add() */
- if (!list_empty (&dev->driver_list) && !list_empty (&dev->bus_list))
+ if (!klist_node_attached(&dev->knode_driver) && !klist_node_attached(&dev->knode_bus))
device_release_driver(dev);

dev->driver = NULL;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/