Re: [PATCH] Replaces two GOTO statements with one IF_ELSE statementin /fs/open.c

From: Joel Schopp
Date: Mon Jun 20 2005 - 15:15:50 EST

Christoph Lameter wrote:

On Mon, 20 Jun 2005, Jeff Garzik wrote:

If you don't like goto, don't read kernel code!

But his patch also cleans up a code quit a bit.

As a wider question, what is the practice for accepting patches without functional changes that simply clean up code and make it look better?

BTW, I also agree that the gotos in this case keep the normal code flow cleaner, while making the exceptions isolated well.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at