Re: [PATCH] Small kfree cleanup, save a local variable.

From: Jesper Juhl
Date: Sun Jun 19 2005 - 14:51:44 EST

On 6/19/05, Michael Buesch <mbuesch@xxxxxxxxxx> wrote:
> Quoting Jesper Juhl <juhl-lkml@xxxxxx>:
> > Here's a patch with a small improvement to kernel/auditsc.c .
> > There's no need for the local variable struct audit_entry *e ,
> > we can just call kfree directly on container_of() .
> Did you look at the assembly output? Does it change?
> I think the compiler optimizes this variable away, anyway.
> So, if there's no improvement, I would personally prefer the
> original form as it's more readable.
gcc does optimize it away.
Personally I find both forms equally readable, and with the change the
source matches what the code actually ends up as, but I don't care
much one way or the other.

Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post
Plain text mails only, please
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at