Re: [PATCH linux-2.6.12-rc6-mm1] blk: elevator unplug thresh hanlding fix

From: Jens Axboe
Date: Thu Jun 16 2005 - 01:58:57 EST


On Thu, Jun 16 2005, Tejun Heo wrote:
> Hello, Jens.
> Hello, Andrew.
>
> This patch fixes q->unplug_thresh condition check in
> __elv_add_request(). rq.count[READ] + rq.count[WRITE] can increase
> more than one if another thread has allocated a request after the
> current request is allocated or in_flight could have changed resulting
> in larger-than-one change of nrq, thus breaking the threshold
> mechanism.

Looks good, thanks!

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/