Re: [PATCH 2/2] mbind: check_range use standard ptwalk

From: Andi Kleen
Date: Tue Jun 07 2005 - 09:41:31 EST


On Mon, Jun 06, 2005 at 08:49:38PM +0100, Hugh Dickins wrote:
> Strict mbind's check for currently mapped pages being on node has been
> using a slow loop which re-evaluates pgd, pud, pmd, pte for each entry:
> replace that by a standard four-level page table walk like others in mm.
> Since mmap_sem is held for writing, page_table_lock can be taken at the
> inner level to limit latency.

I doubt you will be able to benchmark a difference since the inner loop
should be normally memory bound anyways, giving the CPU plenty
of time to do some cache accesses. But ok.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/