Re: patch] Real-Time Preemption, plist fixes

[Thomas Gleixner]

On Sat, 2005-06-04 at 17:53 -0700, Daniel Walker wrote:

> You mean really annoying in the plist code?

Usually I mean what I write.
 
> > 2. Add the proper list_head initializer in the replacement path.
> 
> Not sure what you mean here.

      list_replace_rcu(&pl->dp_node, &pl_new->dp_node);
+     INIT_LIST_HEAD(&pl->dp_node);

 
> > 4. Make plist_entry() work as expected by anybody who ever used
> > list_entry(). Add a plist_first_entry macro for those places where the
> > provided functionality was accidentaly correct.
> >
> I already released a patch to fix this.

Nice to know. Where ?

> > 5. Modify the comments in the header file to explain the real intention
> > of the implemenation.
>
> You should wait till it's stable before you finalize the documentation.

Thats plain wrong. Having explanations in place which do not match the
code is worse than no explanation at all.

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/