Re: [PATCH] Support for read-only MMC cards

[Russell King]

On Sat, Jun 04, 2005 at 10:14:15PM +0200, Pierre Ossman wrote:
> Well that would turn out something like:
> 
>     printk(KERN_INFO "%s: %s %s %dKiB%s\n",
>         md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
>         (card->csd.capacity << card->csd.read_blkbits) / 1024,
>         (!(card->csd.cmdclass & CCC_BLOCK_WRITE) ||
> mmc_card_readonly(card)) ? " (ro)" : "");
> 
> which is a bit messy IMHO.

Can't we set mmc_card_readonly status if !CCC_BLOCK_WRITE ?  Would that
not simplify the code in the open method as well?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/