Re: [PATCH] Support for read-only MMC cards

[Russell King]

On Sat, Jun 04, 2005 at 09:54:53PM +0200, Pierre Ossman wrote:
> If the card does not support the write commands then only allow
> read-only access.

> @@ -403,9 +407,12 @@ static int mmc_blk_probe(struct mmc_card
>  	if (err)
>  		goto out;
>  
> -	printk(KERN_INFO "%s: %s %s %dKiB\n",
> +	printk(KERN_INFO "%s: %s %s %dKiB",
>  		md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
>  		(card->csd.capacity << card->csd.read_blkbits) / 1024);
> +	if (!())
> +		printk(" (ro)");
> +	printk("\n");

I'd prefer this to be:

	printk(KERN_INFO "%s: %s %s %dKiB%s\n",
 		md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
 		(card->csd.capacity << card->csd.read_blkbits) / 1024,
		card->csd.cmdclass & CCC_BLOCK_WRITE ? "" : " (ro)");

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/