Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new DellBIOS update driver

[Greg KH]

On Thu, Jun 02, 2005 at 05:25:46PM -0500, Abhay_Salunke@xxxxxxxx wrote:
> +/sys/firmware/dell_rbu/monolithic/mono_name
> +/sys/firmware/dell_rbu/monolithic/mono_size
> +/sys/firmware/dell_rbu/packetized/packet_name
> +/sys/firmware/dell_rbu/packetized/packet_size
> +
> +Steps to update the BIOS image:
> +
> +1> Copy the image file in to /lib/firmware 
> +2> echo the image name in to /sys/firmware/dell_rbu/xxxx/xxxx_name

No no no.  Just because you are using the firmware interface, does not
mean you need to add this extra round-trip to the whole system.  Just
dump the firmware to the /sys/firmware/whatever... file whenever you
want to, that's all that is needed.  No hotplug stuff, no filename
stuff, just a simple copy.

Also, see the -mm tree for a change in the way the sysfs attributes
work, that will keep you from having to do the .type stuff all over the
place.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/