Re: [patch 5/11] s390: #ifdefs in compat_ioctls.

From: Christoph Hellwig
Date: Wed Jun 01 2005 - 13:50:30 EST


On Wed, Jun 01, 2005 at 08:03:12PM +0200, Martin Schwidefsky wrote:
> [patch 5/11] s390: #ifdefs in compat_ioctls.
>
> From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>
> Remove superflous #if .. #endif pairs from compat_ioctl.c.

Actually is there any chance you could just provide ->compat_ioctl handlers
in the drivers? All these ioctls are specific to drivers, and it sounds like
a rather bad idea to pollute the global has table with them. This is also
a good chance to switch the drivers to drop BKL usage in the ioctl path and
use the same handler for ->unlocked_ioctl and ->compat_ioctl.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/