Re: [patch] Real-Time Preemption, -RT-2.6.12-rc4-V0.7.47-06

[Daniel Walker]

On Wed, 1 Jun 2005, Ingo Molnar wrote:

> 
> * Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> 
> > Another problem in plist_add:
> > 
> > > existing_sp_head:
> > > 	itr_pl2 = container_of(itr_pl->dp_node.prev, struct plist, dp_node);
> > > 	list_add(&pl->sp_node, &itr_pl2->sp_node);
> > 
> > This breaks fifo ordering.
> 
> Daniel, is the issue (and other issues) Oleg noticed still present? I'm 
> still a bit uneasy about the complexity of the plist changes.

I think this one isn't right. We could make a test quite to check
correctness. Find the errors before they find us. Oleg may even have
something like that already half done. 

Are you concerned with plist as a whole, or just my recent changes?

There is still a problem with plist_for_each() missing the first list
member, which I need to fix. 

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/