Re: [patch 06/16] Fix matroxfb on big-endian hardware

[Chris Wright]

* Al Viro (viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx) wrote:
> On Mon, May 23, 2005 at 04:22:07PM -0700, Chris Wright wrote:
> > -				mga_writel(mmio, 0, *chardata);
> > +#if defined(__BIG_ENDIAN)
> > +				fb_writel((*chardata) << 24, mmio.vaddr);
> > +#else
> > +				fb_writel(*chardata, mmio.vaddr);
> > +#endif
> 
> So basically you are passing it cpu_to_le32(*chardata)?
> 
> > +#if defined(__BIG_ENDIAN)
> > +				fb_writel((*(u_int16_t*)chardata) << 16, mmio.vaddr);
> > +#else
> > +				fb_writel(*(u_int16_t*)chardata, mmio.vaddr);
> > +#endif
> 
> *yuck*
> 
> cpu_to_le32(le16_to_cpu(*(__le16 *)chardata)?  Is that what you are doing
> here?

Petr, care to comment?  Best I can tell this is from you and is already
upstream.  Any reason not to use cpu_to_xx instead of what's done?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/