Re: [PATCH] namespace.c: cleanup in mark_mounts_for_expiry()

[Miklos Szeredi]

> Looks sane.  However, we still have a problem here - just what would
> happen if vfsmount is detached while we were grabbing namespace
> semaphore?  Refcount alone is not useful here - we might be held by
> whoever had detached the vfsmount.  IOW, we should check that it's
> still attached (i.e. that mnt->mnt_parent != mnt).  If it's not -
> just leave it alone, do mntput() and let whoever holds it deal with
> the sucker.  No need to put it back on lists.

Right.  I'll fix that too.

On a bit unrelated node, in do_unmount() why is that
DQUOT_OFF()/acct_auto_close() thing only called for the base of a tree
being detached, and not for any submounts?  Is that how it's supposed
to work?

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/