Re: [PATCH] Fix to virtual terminal UTF-8 mode handling

From: Andrew Morton
Date: Tue May 17 2005 - 22:02:46 EST


Paul LeoNerd Evans <leonerd@xxxxxxxxxxxxxx> wrote:
>
> This patch fixes a bug in the virtual terminal driver, whereby the UTF-8
> mode is reset to "off" following a console reset, such as might be
> delivered by mingetty, screen, vim, etc...

Is it a bug? What did earlier kernels do? 2.4.x?

> Rather than resetting to hardcoded "0", it gets reset on or off, as
> determined by a new sysctl located in /proc/tty/vt/default_utf8_mode.
> This patch is best accompanied with an addition of the following line to
> the system's init scripts:
>
> echo 1 >/proc/tty/vt/default_utf8_mode
>
> Following this, all resets to the console will leave it with UTF-8 mode
> on.
>
> The default behaviour of this sysctl is as before, without the patch.
> Namely, UTF-8 mode is switched off on reset. [I.e applying this patch
> does not affect default behaviour].

Presumably userspace knows what mode the user wants the terminal to be
using. Shouldn't userspace be resetting that mode after a reset?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/