Re: [PATCH 7/8] ppc64: SPU file system

From: Andi Kleen
Date: Sun May 15 2005 - 06:25:56 EST


Greg KH <greg@xxxxxxxxx> writes:
>
> No, as Ben said, do not do this. Use write. And as you are only doing
> 1 type of ioctl, it shouldn't be an issue. Also it will be faster than
> the ioctl due to lack of BKL usage :)

The problem is that if something is wrong regarding 32bit/64bit
compatibility (I am not saying Arnd will get it wrong, but
for a general rule someone will get it wrong and it has happened, e.g.
in ubsfs) then it is impossible to do any compat emulation
on read/write.

So I would actually prefer ioctl because it is sfer.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/