Re: [PATCH] pcmcia/ds: handle any error code

[randy_dunlap]

On Fri, 13 May 2005 15:45:49 -0400 Wakko Warner wrote:

| randy_dunlap wrote:
| > On Thu, 12 May 2005 19:02:06 -0400 Wakko Warner wrote:
| > There is some small difference in locking in fs/char_dev.c between
| > 2.6.12-rc4 and 2.6.11.8, but I don't yet see why it would cause a
| > failure in register_chrdev().
| > 
| > Oh, there's a big difference in drivers/pcmcia/ds.c, lots of probe
| > changes.  This is where to look further (but not tonight).
| > The question then becomes is this a real regression?
| > 
| > Do you suspect a problem with -Os code generation?
| 
| I just tried it, it doesn't give me any errors.  This is strange considering
| that I a) use a pristine tree for each kernel (only coping the .config) and
| b) the patch doesn't do anything except report the error.  I made my boot
| floppy (the scripts I use pull from the kernel tree I specify and make the
| image I need) and booted from it.  I placed the modules on my stage2 disk
| that was made and it works.
| 
| I don't have the time this week to try again from scratch.  I'll see if I
| can do it next week.

I'm currently running a kernel built with -Os.  I can successfully
load pcmcia_core.ko and pcmcia.ko.  I added debug printk's in
drivers/pcmcia/ds.c and it allocates the dynamic major dev
successfully:
[4294809.055000] register_chrdev: returning 254
[4294809.060000] pcmcia major device = 254


What gcc version are you using?  (gcc 4.0 has a few known issues.)

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/