Re: [RFC][PATCH] timers fixes/improvements

[Greg KH]

On Wed, May 11, 2005 at 08:12:16AM -0700, Christoph Lameter wrote:
> We found that this has nothing to do with the timer patches. There is a
> scribble in pcie_rootport_aspm_quirk that overwrites ptype_all.

Ick.

> quirk_aspm_offset[GET_INDEX(pdev->device, dev->devfn)]= cap_base + 0x10;
> 
> does the evil deed. The array offset calculated by GET_INDEX is out of
> bounds.
> 
> The definition of GET_INDEX is suspect:
> 
> #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + b)
> 
> should this not be
> 
> #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + \
> 				((b) & 7))
> 
> ?

Dely, any thoughts about this, or know who would know about it?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/