Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)

From: Adrian Bunk
Date: Wed May 11 2005 - 18:03:14 EST


On Wed, May 11, 2005 at 12:07:55PM +0100, Paulo Marques wrote:
> Jesper Juhl wrote:
> >On Tue, 10 May 2005, Andrew Morton wrote:
> >
> >>Jesper Juhl <juhl-lkml@xxxxxx> wrote:
> >>
> >>>[...]
> >>>Ohh, and I'd be submitting all the patches to you Andrew, not individual
> >>>maintainers/authors..
> >>
> >>That should be OK - you can test that the .o files have the same `size'
> >>output before-and-after.
> >>
> >>[...]
> >
> >Ok, will do.
>
> Just a small sugestion: do a sha (or md5sum, or whatever hash function
> you prefer) to vmlinux before and after applying the patches.
>
> If all is well, it shouldn't change (since this is just whitespace
> cleanup), and it is a little more robust than just checking the size.


That's wrong.

vmlinux contains the date of the compilation.


> Paulo Marques - www.grupopie.com


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/