Re: [Lse-tech] [PATCH] cpusets+hotplug+preepmt broken

From: Paul Jackson
Date: Wed May 11 2005 - 15:49:07 EST


Nathan asked:
> Won't holding cpuset_sem while calling cpuset_cpus_allowed cause a
> deadlock?

It definitely would, which is why Dinakar's patch both added a call to
get cpuset_sem earlier in the hot unplug code, as well as removed the
call to get cpuset_sem that was inside the cpuset_cpus_allowed code (as
well as modified the other caller of cpuset_cpus_allowed, the
sched_setaffinity code, to explicitly get cpuset_sem before calling
cpuset_cpus_allowed, since that call no longer acquired cpuset_sem on
its own.


--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxxxxxxx> 1.650.933.1373, 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/