Re: [PATCH] kernel/module.c has something to hide. (whitespacecleanup)

[Andrew Morton]

"David S. Miller" <davem@xxxxxxxxxxxxx> wrote:
>
> From: Andrew Morton <akpm@xxxxxxxx>
> Subject: Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)
> Date: Tue, 10 May 2005 16:16:57 -0700
> 
> > Jesper Juhl <juhl-lkml@xxxxxx> wrote:
> > >
> > > -	if (b == NULL || already_uses(a, b)) return 1;
> > > +	if (b == NULL || already_uses(a, b))
> > > +		return 1;
> > 
> > There are about 88 squillion of these in the kernel.  I think it would be a
> > mistake for me to start taking such patches, sorry.
> 
> I disagree.  Putting statements on the same line as
> the if statement hides bugs and makes the code harder
> to read.

We all know that, but this means that we spend the next two years fielding
an ongoing dribble of trivial patches which distract from real work.

> Fixing these makes the kernel eaiser to maintain
> and debug.

Well I suppose I could live with a few REALLY REALLY BIG patches to do this
to lots of files, but if it's the old death-by-1000-cuts, I'm gonna call
uncle this time.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/