Re: [PATCH] Fix PCI mmap on ppc and ppc64

From: Andreas Schwab
Date: Tue May 10 2005 - 08:20:06 EST


Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> writes:

> @@ -351,9 +351,12 @@
> *offset += hose->pci_mem_offset;
> res_bit = IORESOURCE_MEM;
> } else {
> - io_offset = (unsigned long)hose->io_base_virt;
> + io_offset = (unsigned long)hose->io_base_virt - pci_io_base;
> + printk("offset: %lx, io_base_virt: %p, pci_io_base: %lx, io_offset: %
> lx\n",
> + *offset, hose->io_base_virt, pci_io_base, io_offset);
> *offset += io_offset;
> res_bit = IORESOURCE_IO;
> + printk(" -> offset: %lx\n", *offset);

I don't think you want those debugging printks be left here.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/