Re: PPC uImage build not reporting correctly

[Kumar Gala]

On May 6, 2005, at 6:22 PM, <cpclark@xxxxxxxxxxxx> wrote:

> On Fri, 6 May 2005, Kumar Gala wrote:
>  > I tried the following w/o success:
>  >
> > $(obj)/uImage: $(obj)/vmlinux.gz
> >         $(Q)rm -f $@
>  >         $(call if_changed,uimage)
> >         @echo '  Image: $@' $(shell if [ -f $@ ]; then echo 'is 
> ready'; else
>  > echo 'not made'; fi)
>
> Couldn't you eliminate the ($shell ..) construct altogether, like 
> this?:
>
> $(obj)/uImage: $(obj)/vmlinux.gz
>         $(Q)rm -f $@
>          $(call if_changed,uimage)
>         @echo -n '  Image: $@'
>          @if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi

Yes, and this seems to actually work.

Sam, does this look reasonable to you.  If so I will work up a patch.

thanks

- kumar

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/