Re: [PATCH 2.6.12-rc3-mm3] perfctr: x86 update with K8 multicorefixes

[Andi Kleen]

Mikael Pettersson <mikpe@xxxxxxxxx> writes:

> Andrew,
>
> Here's an update for perfctr's x86/x86-64 low-level driver
> which works around issues with current K8 multicore chips.
>
> - Added code to detect multicore K8s and prevent threads in the
>   thread-centric API from using northbridge events. This avoids
>   resource conflicts, and an erratum in Revision E chips.

How about you just check cpu_core_map[] instead of adding your
own custom detection code for this? This seems quite bogus to me.
After all we have central CPU feature detection so that not everybody
reinvents all this on its own.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/