Re: [PATCH: 1 of 12] Fix concerns with TPM driver -- use enums

From: Greg KH
Date: Wed Apr 27 2005 - 17:31:39 EST

On Wed, Apr 27, 2005 at 05:15:46PM -0500, Kylene Hall wrote:
> /* Atmel definitions */
> -#define TPM_ATML_BASE 0x400
> +enum {
> + TPM_ATML_BASE = 0x400
> +};

Please name your enumerated types, so that you can try to check for
type-safeness on them. Just converting them to a enum doesn't do really


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at