Re: [PATCH] private mounts

From: Jan Hudec
Date: Wed Apr 27 2005 - 07:02:03 EST

On Wed, Apr 27, 2005 at 12:42:04 +0200, Miklos Szeredi wrote:
> > > This is the controversial part in all it's glory:
> > >
> > > if (!(fc->flags & FUSE_ALLOW_OTHER) && current->fsuid != fc->user_id)
> > > return -EACCES;
> > >
> > > Leaving it out would gain us what exactly?
> >
> > Well, if it brings us ugly semantics, keeping those two lines out for
> > a while can help merge a lot...
> To the mount owner the semantics are quite normal. Others will be
> denied access to the mountpoint, which doesn't introduce any new
> semantics either.

What makes you think Pavel was talking about semantics?!

The point was that:
Ok, there is a strong disagreement about these two lines. Could we have
a patch with everything but these two lines, so it can be integrated
immediately to profit of the testing and generally be useful, and then
the controversial bits when the issue is beaten to death?

So, please, could you send a stripped-down version, that is not safe for
mounting by users, but can be tested for many cases where that is

> If you look at it from the POV of _any_ process, there are NO NEW
> SEMANTICS. Nothing that programs, scripts or anything has to be
> modified for. Nothing that could cause _any_ problems later, if this
> check was removed.
> Prove me wrong!

As I understand it, doing things like this is butt ugly. Not just in
fuse -- in NFS, in samba, everywhere where such hacks are employed. But
now they just have enough of those hacks and want a cleaner solution.

Jan 'Bulb' Hudec <bulb@xxxxxx>

Attachment: signature.asc
Description: Digital signature