Re: [PATCH] x86_64: handle iret faults better

From: Linus Torvalds
Date: Mon Apr 25 2005 - 11:00:16 EST

On Mon, 25 Apr 2005, Andi Kleen wrote:
> But I really hate your is_iret hack in traps.c.

I agree.

Why don't you just do

pushl $0
pushl $do_iret_error
jmp error_code

And just have a "do_iret_error()" handler in traps.c which does the right
thing? That seems like the _sane_ thing to do, and that way there is never
any confusion about what is going on.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at